🧹 In cypress, use getBySel("") instead of get('[data-cy=""]') #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasan-sh
requested changes
May 30, 2024
There was a problem hiding this comment.
There are still places where .get("[data-cy='.... is used. For instance, in
- https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/for-teacher_page/class_page/second_teachers_invites.cy.js#L55
- https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/for-teacher_page/general/preview-class.cy.js
- https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/hedy_page/quiz.cy.js
- https://github.com/hedyorg/hedy/blob/main/tests/cypress/e2e/public_programs/programs_page.cy.js
- ...
Perhaps do a search for data-cy in all .cy.js files, so that you can change them everywhere!
|
@hasan-sh Thanks for the contribution, looks good! Can you fix the tests? Then it's ready I think |
hasan-sh
approved these changes
Jun 3, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lot cleaner to read:
cy.getBySel('view_class_link')instead of:
cy.get('[data-cy="view_class_link"]')