Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Reduce achievements time #5605

Merged
merged 7 commits into from
Jun 12, 2024
Merged

💻 Reduce achievements time #5605

merged 7 commits into from
Jun 12, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Jun 7, 2024

While working on another PR I found out that a new user that tries to create a class has to wait a lot of time for their first class to show. This happens because the showAchievements functions has some timeouts of 6 seconds, so the user, as a minimum has to wait this long if they get an achievement.

Therefore I reduced the time of the achievements a bit.

How to test

  • Log in as teacher3
  • Create a class
  • The class shouldn't take ages to load

Other way to test:

  • Log in as teacher1
  • Duplicate a class
  • The for teachers page should reload quickly

You can try that on main and see the difference (remember to clear the site data and restore the devdb in order for the achievement to be shown again)

@jpelay jpelay requested a review from Annelein June 11, 2024 16:27
static/js/app.ts Outdated Show resolved Hide resolved
@Annelein Annelein self-requested a review June 12, 2024 13:53
Copy link
Contributor

mergify bot commented Jun 12, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b4abbe2 into main Jun 12, 2024
12 checks passed
@mergify mergify bot deleted the reduce_achv_time branch June 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants