Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲Fix not being able to complete the quiz while in programmer's mode #5615

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Jun 14, 2024

If the developers mode was enabled, then the parsons and the quiz became unusable. To solve this I split the logic into two functions: one to set the developers mode and another to show it. Now you can actually complete the quiz and the parsons while in this mode.

Fixes #5172

How to test

  • Check the programmer's mode toggle while being logged off and check that you can complete the quiz and the parsons.
  • As a student of a class with mandatory programmer's mode check that you can complete the quiz and the parsons (I wonder if teachers use this feature much being that no one complained about this before recently)

@Annelein Annelein self-assigned this Jun 17, 2024
@Annelein Annelein self-requested a review June 17, 2024 13:40
Copy link
Contributor

mergify bot commented Jun 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3c960ee into main Jun 17, 2024
12 checks passed
@mergify mergify bot deleted the fix_developers_mode branch June 17, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 Parsons become unusable if developers mode is activated
2 participants