Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Tags: remove double get, sort tags #5620

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

rix0rrr
Copy link
Collaborator

@rix0rrr rix0rrr commented Jun 18, 2024

Two tiny changes ported over from #5431:

  • Remove a duplicate database retrieval when looking up the tags of an adventure.
  • Sort the tags (when they are saved to the database).

How to test

Unsorted tags should be sorted after adding a tag. Otherwise no functional difference.

rix0rrr and others added 2 commits June 18, 2024 19:25
Two tiny changes ported over from #5431:

- Remove a duplicate database retrieval when looking up the tags of an
  adventure.
- Sort the tags (when they are saved to the database).
@Felienne
Copy link
Member

Hi @rix0rrr!

This has a failing Cypress test that I suspects fails for good reasons, can you take a look?

Copy link
Contributor

mergify bot commented Jun 25, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5de8f29 into main Jun 25, 2024
12 checks passed
@mergify mergify bot deleted the remove-double-get-sort-tags branch June 25, 2024 12:04
Copy link
Contributor

mergify bot commented Jun 25, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants