Don't wait underlying network buffer to overflow #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinrich5991
force-pushed
the
master
branch
2 times, most recently
from
10cb702
to
aff9b03
Compare
|
This fixes the issue for @gerdoe-jr, however, it doesn't look like the correct fix. This is simply optionally also waiting for a writable socket. A possible correct fix for this would be ignoring the |
|
Created issue #85, closing this PR as it's not the correct solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason my Windows server build crashed every time on
WouldBlockwhich was caused by small network buffer(?) that wasn't able to send messages on time. Thanks to @eof228