Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP draft – PoC Witness IP Check #414

Merged
merged 5 commits into from
Jun 2, 2022
Merged

HIP draft – PoC Witness IP Check #414

merged 5 commits into from
Jun 2, 2022

Conversation

H-Baguette
Copy link
Contributor

@H-Baguette H-Baguette commented May 24, 2022

An attempt at solving Helium's spoofing problem. A discussion with Digerati on Discord allowed me to better understand why the simple solution to invalidate all witnesses sharing the same IP as either the beacon or another witness is not ideal.

Ed: rendered view https://github.com/helium/HIP/blob/defd2f4233650967b548e4115e4f5e4a062030ed/0061-poc-witness-ip-check.md

@edakturk14
Copy link
Contributor

hey @H-Baguette! would you like to present the draft on the community call thats tomorrow?

@H-Baguette
Copy link
Contributor Author

H-Baguette commented May 24, 2022 via email

@edakturk14
Copy link
Contributor

awesome! call details & agenda is here: https://bit.ly/38HQ9Mm
We generally have 15 min for new HIPs how does that sound? We chat from Discord if you're on there to schedule for tomorrow

@snip
Copy link

snip commented May 25, 2022

Looks to be a very good start thanks @H-Baguette!
Even if it is a good step forward it seems this proposal will not stop cheaters using VPN and unique IP to go outside.
But it is difficult to cover everything. So for sure small steps are better than doing nothing!

@softlion
Copy link

softlion commented May 26, 2022

You could also check that IPs are residential and exclude all other types (ie: datacenter IPs).
Explanations here: https://multilogin.com/how-to-hide-ip-address-your-complete-guide/

image

@snip
Copy link

snip commented May 26, 2022

You could also check that IPs are residential and exclude all other types (ie: datacenter IPs).

Unfortunately lot of current hotspot owners moved to VPN for their hotspot to have possibility to forward port 44158 to their hotspot. So they will need to update their setup to remove the VPN.
But yes this can be a target solution. Not yet applicable i think.

@ifeign
Copy link

ifeign commented Jun 2, 2022

You could also check that IPs are residential and exclude all other types (ie: datacenter IPs).

Unfortunately lot of current hotspot owners moved to VPN for their hotspot to have possibility to forward port 44158 to their hotspot. So they will need to update their setup to remove the VPN. But yes this can be a target solution. Not yet applicable i think.

People also use VPNs for remote management

@softlion
Copy link

softlion commented Jun 2, 2022

You could also check that IPs are residential and exclude all other types (ie: datacenter IPs).

Unfortunately lot of current hotspot owners moved to VPN for their hotspot to have possibility to forward port 44158 to their hotspot. So they will need to update their setup to remove the VPN. But yes this can be a target solution. Not yet applicable i think.

People also use VPNs for remote management

For management they use a secondary network on vpn, which does not get all 'normal' traffic from hotspots.

@pilotdeveloper
Copy link

as the owner of virtualprivatepi.com, I can assure you that people use VPN providers for remote management - tailscale is too far beyond them for most cases.

This is also going to significantly impact CGNat devices in a negative way. All hotspots deployed on LTE / 5G hotspots are currently sharing the same public IP - this filter would screw them over.

Added restrictions on the use of VPN. A hotspot's IP's location must match its registered location on the Helium explorer, at a national level. If the countries don't match, the witness is invalidated.
@H-Baguette
Copy link
Contributor Author

Keep in mind that CGNAT devices would only be affected if they share the same IP, are in the same beaconing event (witnessing each other or witnessing the same beacon), and are isolated from any other valid hotspots. This proposal does not automatically invalidate all witnessing sharing the same IP all over the network, but only those sharing an IP locally and under specific conditions.

@ifeign
Copy link

ifeign commented Jun 2, 2022 via email

@jamiew jamiew added the draft label Jun 2, 2022
@jamiew jamiew changed the title Create 0061-poc-witness-ip-check.md HIP draft – PoC Witness IP Check Jun 2, 2022
@hiptron
Copy link
Collaborator

hiptron commented Jun 2, 2022

This HIP draft has been numbered and merged for discussion as HIP 62.

Please direct future questions & comments to the new tracking issue: #422

If you are one of the named authors, please include #422 in future pull requests to have them automatically merged.

@hiptron hiptron merged commit 28db939 into helium:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants