Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Challenges API call not using all parameters #315

Open
mrKlar opened this issue Jul 12, 2022 · 0 comments · May be fixed by #326
Open

Challenges API call not using all parameters #315

mrKlar opened this issue Jul 12, 2022 · 0 comments · May be fixed by #326

Comments

@mrKlar
Copy link

mrKlar commented Jul 12, 2022

Hi,

the library do not use all parameters on the challenges API call, only the cursor one. It should implement the whole spec.

challengesdoc

thanks,
markdegrootnl added a commit to markdegrootnl/helium-js that referenced this issue Jul 29, 2022
@markdegrootnl
Added all parameters to Challenges api
3a5b05e 
Fixes helium#315 by adding `min_time`, `max_time` and `limit` parameters to the Challenges api call.
@markdegrootnl markdegrootnl linked a pull request Jul 29, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added all parameters to Challenges api markdegrootnl/helium-js
1 participant
@mrKlar