Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/934 validators filters #946

Merged
merged 7 commits into from
Sep 20, 2021
Merged

Feature/934 validators filters #946

merged 7 commits into from
Sep 20, 2021

Conversation

matthewcarlreetz
Copy link
Contributor

No description provided.

tyler-whitman
tyler-whitman approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@tyler-whitman tyler-whitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and working well for me, only other thing I noticed is that the HNT amount for the validator list item doesn't convert to local currency when using the toggle. Thats the way it works it is on the consensus list too though.

@matthewcarlreetz
Copy link
Contributor Author

Code looks good and working well for me, only other thing I noticed is that the HNT amount for the validator list item doesn't convert to local currency when using the toggle. Thats the way it works it is on the consensus list too though.

oh, good catch. I'll fix that.

@tyler-whitman
Copy link
Contributor

Code looks good and working well for me, only other thing I noticed is that the HNT amount for the validator list item doesn't convert to local currency when using the toggle. Thats the way it works it is on the consensus list too though.

oh, good catch. I'll fix that.

Looks good to merge when you are ready!

@matthewcarlreetz matthewcarlreetz merged commit 82c438c into main Sep 20, 2021
@matthewcarlreetz matthewcarlreetz deleted the feature/934_validators-filters branch September 20, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-whitman tyler-whitman tyler-whitman approved these changes

@allenan allenan Awaiting requested review from allenan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewcarlreetz @tyler-whitman