Update metrics #805
Merged
Update metrics #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumps metrics-exporter-prometheus. The biggest change from 0.21 -> 0.22 is in this PR metrics-rs/metrics#394
michaeldjeffrey
requested review from
maplant,
macpie,
andymck,
bbalser and
jeffgrunewald
bbalser
reviewed
May 4, 2024
this may change if the api to metrics changes _again_ before a major version.
michaeldjeffrey
added a commit
that referenced
this pull request
May 6, 2024
* Update metrics crate Also bumps metrics-exporter-prometheus. The biggest change from 0.21 -> 0.22 is in this PR metrics-rs/metrics#394 * allow for versions greater than 0.22 this may change if the api to metrics changes _again_ before a major version.
michaeldjeffrey
added a commit
that referenced
this pull request
May 6, 2024
* Add client_requests timing module to metrics
- Add a timing span to anything that can be instrumented and returns a Result.
Example:
```ignore
let client = GatewayClient::new(channel);
client.info(req)
.with_timing("iot_fetch_info")
.await?;
```
This will result in a prometheus metric
>> client_request_duration_seconds{name = "iot_fetch_info", quantile="xxx"}
- Install the `ApiTimingLayer`.
Adding `.with_span_events(FmtSpan::CLOSE)` to a regular format layer will
print the timing spans to stdout as well.
Example:
```ignore
tracing_subscriber::registry()
.with(tracing_subscriber::fmt::layer().with_span_events(FmtSpan::CLOSE))
.with(metrics::client_requests::client_request_timing_layer("histogram_name"))
.init();
```
- Remove unused `install_metrics` function, replace with nested
`install` function that `start_metrics` delegates to. This allows us to
start metrics in tests without needing to make a `Settings` struct.
* Update metrics (#805)
* Update metrics crate
Also bumps metrics-exporter-prometheus.
The biggest change from 0.21 -> 0.22 is in this PR
metrics-rs/metrics#394
* allow for versions greater than 0.22
this may change if the api to metrics changes _again_ before a major version.
* make string values consts
Makes the values hide a little bit less in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pointing into
mj/telemetry-histogramsbranch to ease reviewing. This update changes a lot of files.Also bumps metrics-exporter-prometheus.
The biggest change from 0.21 -> 0.22 is in this PR metrics-rs/metrics#394