Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests #115

Closed
kirawi opened this issue Jun 4, 2021 · 7 comments
Closed

Integration tests #115

kirawi opened this issue Jun 4, 2021 · 7 comments
Labels
C-enhancement Category: Improvements E-help-wanted Call for participation: Extra attention is needed

Comments

@kirawi
Copy link
Member

kirawi commented Jun 4, 2021

I'm wondering if it would be practical to have a set of integration tests, especially to test hotkeys & rendering. Having it available for monkeys like me would make it a lot easier to test if everything is running correctly.

@pickfire
Copy link
Contributor

pickfire commented Jun 4, 2021

The kakoune approach of integration tests is interesting. But I wonder if we can do something like rust compiler sort of ui tests, like using comments? I think this is in @archseer todo. @kirawi are you interested in doing this?

@kirawi
Copy link
Member Author

kirawi commented Jun 4, 2021

Unfortunately, I'm not very familiar with creating tests, and I will be too busy :(

@pickfire pickfire added the C-enhancement Category: Improvements label Jun 4, 2021
@archseer
Copy link
Member

archseer commented Jun 7, 2021

For integration tests, we can probably construct an Editor with a single document, wrap it in a ui::Editor then call handle_events to inject keys.

@kirawi
Copy link
Member Author

kirawi commented Jun 12, 2021

I'll be creating a testing harness for #228

@kirawi
Copy link
Member Author

kirawi commented Aug 19, 2021

@archseer Do we still need this issue? I no longer feel as strongly about integration tests specifically.

@archseer
Copy link
Member

Yes, integration tests are important. Probably even more than the current set of unit tests.

@archseer archseer changed the title Integration Tests Integration tests Aug 22, 2021
@kirawi kirawi added the E-help-wanted Call for participation: Extra attention is needed label Oct 12, 2021
@dead10ck
Copy link
Member

This was done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements E-help-wanted Call for participation: Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants