-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding More Tests for Commands & Movement #144
Comments
I agree. Not only would it be nice to have it tested, it would serve us well in terms of catching regressions. 🙂 What kind of tests are you envisioning? While unit tests are nice, I think integration tests would be ideal here. I remember mle having pretty sweet integration tests as an example. |
I was thinking of having basic unit tests to check for correct behaviour and that it doesn't panic, and then later on have integration tests to address #115 and basically include complicated cases, combos, etc. However, I think this and that should be considered separate issues. Feel free to disagree, I don't have much experience in this area so I'll defer to you. |
kakoune have nice integration tests, we could do some macros for these. |
I'm happy to write a few of these, as it tends to be what I do when I'm wrapping my head around a codebase anyway :). Feel free to assign me if nobody else is on this. |
Can this be considered completed or do we want to improve our test coverage further in this specific portion of Helix? |
We extensively covered movement but I'd still like to cover other commands. |
This is covered by #115 |
I think it would be beneficial to thoroughly test
helix-core/src/movement.rs
&helix-term/src/commands.rs
. To start, it would probably be most important to test the functions transitively called by hotkeys inhelix-term/src/keymap.rs
. This could also be a good first issue.The text was updated successfully, but these errors were encountered: