Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SVG files #6337

Closed
IvanGoncharov opened this issue Mar 16, 2023 · 1 comment · Fixed by #6431
Closed

Add support for SVG files #6337

IvanGoncharov opened this issue Mar 16, 2023 · 1 comment · Fixed by #6431
Labels
C-enhancement Category: Improvements

Comments

@IvanGoncharov
Copy link

SVG files contain XML so it should be easy to add since Helix already supports XML.
I tried to add SVG support locally by adding following to my languages.toml:

[[language]]
name = "svg"
file-types = ["svg"]
scope = "svg"
injection-regex = "svg"
indent = { tab-width = 2, unit = "  " }
roots = []
grammar = "XML"

But it doesn't work 🤷‍♂️

@IvanGoncharov IvanGoncharov added the C-enhancement Category: Improvements label Mar 16, 2023
@IvanGoncharov IvanGoncharov changed the title Add support for SVG Add support for SVG files Mar 16, 2023
@A-Walrus
Copy link
Contributor

If we don't want to do anything SVG specific, I think we can just add .svg to the list of xml file extensions.

matoous added a commit to matoous/helix that referenced this issue Mar 24, 2023
Add "svg" as a file type for xml.

Fixes: helix-editor#6337
the-mikedavis pushed a commit that referenced this issue Mar 25, 2023
Add "svg" as a file type for xml.

Fixes: #6337
Triton171 pushed a commit to Triton171/helix that referenced this issue Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this issue Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants