-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new theme keys for LSP diagnostic tags #10064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the base16_
and term16_
themes should be reset - those themes are meant to be used in barebones terminals that most likely won't support the dim or crossed out modifiers
814449d
to
ec92d2c
Compare
ah! okay. I've reset the changes for (I was initially thinking about skipping those themes, but had included them after noticing the use of crossed out and dim modifiers for markups configuration in them.) Thanks |
Hello,
I noticed that the new LSP Diagnostic theme keys (#9780) have been added only to a few themes (#9949, #9967).
So, I've tried to add them to the remaining themes (under
helix/runtime/themes/
) excluding the inherited themes (i.e. themes withinherits
property).Screenshot:
gruvbox_dark_hard
helix/runtime/themes/
)jetbrains_dark.toml
,dark_plus.toml
base16_
(4 files) andterm16_
(1 file)Note: Looks like the following themes do not contain any diagnostic theme keys (apart from the ones I added) -
dracula_at_night.toml
,material_deep_ocean.toml
,snazzy.toml
(Edit01: moved the 'Note' out of table to fix formatting)
(Edit02: updated the summary)
Thanks