Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new theme keys for LSP diagnostic tags #10064

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

krish-r
Copy link
Contributor

@krish-r krish-r commented Mar 31, 2024

Hello,

I noticed that the new LSP Diagnostic theme keys (#9780) have been added only to a few themes (#9949, #9967).

So, I've tried to add them to the remaining themes (under helix/runtime/themes/) excluding the inherited themes (i.e. themes with inherits property).

Screenshot: gruvbox_dark_hard
image

Summary:
Total Themes 134 (under helix/runtime/themes/)
Inherited Themes 44 (skipped)
Themes with latest diagnostic tags 2 (skipped) - jetbrains_dark.toml, dark_plus.toml
Modified Themes 83 (skipped) - base16_ (4 files) and term16_ (1 file)

Note: Looks like the following themes do not contain any diagnostic theme keys (apart from the ones I added) - dracula_at_night.toml, material_deep_ocean.toml, snazzy.toml

(Edit01: moved the 'Note' out of table to fix formatting)
(Edit02: updated the summary)

Thanks

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the base16_ and term16_ themes should be reset - those themes are meant to be used in barebones terminals that most likely won't support the dim or crossed out modifiers

@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Mar 31, 2024
@krish-r
Copy link
Contributor Author

krish-r commented Mar 31, 2024

ah! okay. I've reset the changes for base16_ and term16_ themes.

(I was initially thinking about skipping those themes, but had included them after noticing the use of crossed out and dim modifiers for markups configuration in them.)

Thanks

@pascalkuthe pascalkuthe merged commit 47ef9f0 into helix-editor:master Mar 31, 2024
6 checks passed
@krish-r krish-r deleted the diagnostic-tags branch March 31, 2024 14:29
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants