Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mouse right click selection #10067

Merged
merged 6 commits into from
Apr 8, 2024
Merged

fix mouse right click selection #10067

merged 6 commits into from
Apr 8, 2024

Conversation

diegostafa
Copy link
Contributor

fix #10066

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label Mar 31, 2024
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 31, 2024
the-mikedavis
the-mikedavis previously approved these changes Mar 31, 2024
View reviewed changes
@the-mikedavis the-mikedavis added the C-bug Category: This is a bug label Mar 31, 2024
@archseer
Copy link
Member

archseer commented Apr 1, 2024

I think this was somewhat deliberate, we're editing breakpoints which are only supported with column offsets (start of line) in many debuggers

@diegostafa
Copy link
Contributor Author

diegostafa commented Apr 3, 2024 •
edited
Loading

I think this was somewhat deliberate, we're editing breakpoints which are only supported with column offsets (start of line) in many debuggers

i changed it so that when clicking on the margin it edits the breakpoint, and when clicking inside the document it selects the character.
the main issue i have with the previous behaviour is that it just feels wrong to click somewhere and set the selection somewhere else

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 3, 2024
@the-mikedavis the-mikedavis merged commit 92338bc into helix-editor:master Apr 8, 2024
6 checks passed
@diegostafa diegostafa deleted the fix-right-click-selection branch April 9, 2024 07:51
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@diegostafa @postsolar
fix mouse right click selection (helix-editor#10067)
d5dea68
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@diegostafa @mtoohey31
fix mouse right click selection (helix-editor#10067)
ef6dcf2
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@diegostafa @Vulpesx
fix mouse right click selection (helix-editor#10067)
6089b01
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@diegostafa
fix mouse right click selection (helix-editor#10067)
673caee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

right clicking doesn't select the right character
4 participants
@diegostafa @archseer @the-mikedavis @pascalkuthe