Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brighten nord selection highlight #10307

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

VKondakoff
Copy link
Contributor

@VKondakoff VKondakoff commented Apr 8, 2024

When "nord2" color is used in ui.selection it is almost invisible if cursorline highlighting is enabled. Changing the color to "nord3" fixes the issue.

"nord2":

Снимок экрана 2024-04-04 в 13 18 10

"nord3":

Снимок экрана 2024-04-04 в 15 23 26

When "nord2" color is used in ui.selection it is almost invisible
if cursorline highlighting is enabled. Changing the color to "nord3" fixes the issue.
@the-mikedavis the-mikedavis changed the title Change ui.selection color from "nord2" to "nord3" to fix the issue when selection is almost not visible if cursor line highli Brighten nord selection highlight Apr 9, 2024
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 9, 2024
@pascalkuthe pascalkuthe merged commit c5e257b into helix-editor:master Apr 9, 2024
6 checks passed
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
When "nord2" color is used in ui.selection it is almost invisible
if cursorline highlighting is enabled. Changing the color to "nord3" fixes the issue.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
When "nord2" color is used in ui.selection it is almost invisible
if cursorline highlighting is enabled. Changing the color to "nord3" fixes the issue.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
When "nord2" color is used in ui.selection it is almost invisible
if cursorline highlighting is enabled. Changing the color to "nord3" fixes the issue.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
When "nord2" color is used in ui.selection it is almost invisible
if cursorline highlighting is enabled. Changing the color to "nord3" fixes the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants