Improvement to search ordering for :open #11618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We will not add this kind of custon algorithm. The fuzzy matching socring is very sophisticated and usually does a really good job. The case jn that issue just happens to have cases that score the exact same. We should be using length as a tie breaker in those cases (in which case .config would be first) nucleo also has the option to penalize nkn-prefix matches slightly. Both of those would be the right way to address that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds input prefix match-based ordering to the :open command, as suggested by #10766. The best_match function is written in a very rough, non-idiomatic way at the moment, it's subject to change so feel free to send suggestions and optimizations my way.
The example with ".conf" as input is fixed by this patch:
