Add ability to match in next and previous char pairs (2)

[thomasschafer]

Adds the ability to match inside/around the next or previous matching character pair: for instance, with the cursor as █ below:

█ let x = "bar";

typing ]" would select the contents of the string (i.e. bar).

Screen.Recording.2024-09-15.at.10.20.34.mov

Supersedes #11260 based on discussion there.

Partially resolves:

• Automatically jump to matching brackets #1974
• "Match next pair" with `[`/`]` followed by `m` (or: a better `vi"` from VIM) #9895
• Modify matching behavior when it fails to find the matching character #10567

[thomasschafer]

Note: the first commit is essentially just the changes linked in the comment here. I left the two TODO comments in as I couldn't see a nice way to tidy things up without adding unnecessary complexity, but happy to hear any pointers.

[thomasschafer]

Bumping this 🙏

[daedroza]

If I jump to a function, would this patch still support jumping to next and previous function?

[thomasschafer]

If I jump to a function, would this patch still support jumping to next and previous function?

Yes, that still works as it does currently on master

[thomasschafer]

@the-mikedavis apologies for the ping, wondering if you'd mind taking a look at this? 🙏

[the-mikedavis]

I do want to take a look at this soon but I'm about to be away for a while. I have a note written down to give this a look once I'm back in a 2ish weeks.

(I'm in favor of the feature, I just haven't looked at the changes yet)

[pascalkuthe]

Using plaintext search routines isn't right here. This should be based on tree-sitter. The plaintext search gets thrown off by string literals.

In general I think reusing the surround function won't work too well here. The surround function mostly reuses other functions (match_bracket:: and search::) to find pairs and only adds logical necessary for surround. For forwards/reverse search you are looking for a pair fist and then a single (simpler) call to match_bracket/search would suffice.

I would probably be ok with not implementing the tree-sitter based forward/reverse search for now but I would definitly want to see this as a seperate function (likely directly within textobject.rs).

[thomasschafer]

Sorry not sure I'm fully following - mi{ doesn't use treesitter as far as I can tell, so would we want ]{ to behave any differently?

Also, I decided to go with the option of finding the first char within a pair and then using textobject_pair_surround as this allows selection of ranges between characters where the direction is not clear from the bracket e.g. between | characters. ]| works fine to jump between pairs of | in something like foo|bar|baz|, but that wouldn't work if first searching for the | and then calling one of the match_brackets functions. I'm sure I could overcome this by making a bunch of changes in match_brackets but I thought that would add a lot of code - do you think that option would be preferable, or is there a different approach I'm missing?