fix git repo detection on symlinks #11732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if a symlink is opened which points to a file inside a git repo, the git repo is not detected, so there is no diff gutter. This was done because if we used the content of a symlink git object, whose content is a file path, that literal file path would be used as the content of the diff base, producing a diff gutter in the UI that was all additions. On the other hand, because of this, the git diff gutter doesn't work at all on symlinks. We work around both of these problems by resolving symlinks before finding the path's git repo.
dead10ck
force-pushed
the
fix/git-repo-symlink
branch
from
5090314
to
4c11fa7
Compare
archseer
approved these changes
Sep 30, 2024
the-mikedavis
approved these changes
Oct 3, 2024
plul
pushed a commit
to plul/helix
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a symlink is opened which points to a file inside a git repo, the git repo is not detected, so there is no diff gutter. This was done because if we used the content of a symlink git object, whose content is a file path, that literal file path would be used as the content of the diff base, producing a diff gutter in the UI that was all additions.
On the other hand, because of this, the git diff gutter doesn't work at all on symlinks.
We work around both of these problems by resolving symlinks before finding the path's git repo.