Fix null and boolean constants in tree-sitter-nix highlights queries #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead10ck
reviewed
Jan 4, 2022
| @@ -33,6 +33,11 @@ | |||
|
|
|||
| (uri) @string.special.uri | |||
|
|
|||
| ; boolean | |||
| ((identifier) @constant.builtin.boolean (#match? @constant.builtin.boolean "^(true|false)$")) @constant.builtin.boolean | |||
There was a problem hiding this comment.
Should this just be ["true" "false"] @constant.builtin.boolean?
There was a problem hiding this comment.
I think this doesn't work as true and false is recognized as identifier:
thread 'main' panicked at 'Query error at 37:3. Invalid node type true', helix-core/src/syntax.rs:207:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null and boolean literals were previously detected as
variable.builtin. This PR fixes this and detects these as:constant.builtinandconstant.builtin.booleanrespectively