Add jumplist support for the search (closes #1625) #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested changes
Mar 1, 2022
Philipp-M
force-pushed
the
search-jumplist
branch
from
44ff7e0
to
2b3e0db
Compare
archseer
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1625
I'm not sure if this is everything that is required (i.e. if I missed some edge cases), I'm not yet deep into the codebase...
But so far everything seems to be working fine for me.
One thing I noticed with this change, is that if in selection mode and extending (
extend_search_next, extend_search_previous), this is also added into the jumplist, I'm not sure if this good or bad (I like it for now, which is why I left it as is)