feat(languages): SQL #2097
Merged
feat(languages): SQL #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hmm the flake lock change might be from an old nix version I would guess. Which version of the nix binary are you running? |
|
I'm on |
|
I think it might be that the flake follows change (NixOS/nix#6036) that showed up in 2.7.0 makes it so the lock is generated differently than older nix versions. The current flake is generated with 2.7.0. In any case, would you mind dropping it out of this PR since it's unrelated to the SQL change? We can merge it in later if it's reproducible on 2.7.0. I'll clear my store and try again in a bit to see if I can't reproduce it because of what I have cached locally. |
|
Done! |
Closed
adaliaramon
pushed a commit
to adaliaramon/helix-vim
that referenced
this pull request
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got around to adding sql language support. The original PR is here: #1464, but enough has changed since then (no submodules!) that I decided to just create a new branch & PR.
Only thing I'm not sure of is why when I built with nix,
flake.lockchanged so much.