-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lsp): add vala language support #2243
Conversation
cc79c6f
to
86047c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some scopes in highlights.scm
need to be adjusted to match the list here: https://github.com/helix-editor/helix/blob/6047506ec56787e5a87d0dfe9cb90646004becf5/book/src/themes.md#scopes
For example, @float
becomes @constant.numeric.float
, @property
and @field
become @variable.other.member
, @parameter
becomes @variable.parameter
, etc.
updated, PTAL |
chore: adjust vala boolean, character, regex PTAL |
Toggling block comments is not currently supported (see #1505 and #1937 (comment)). For now, just the line comment will do 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these suggested edits make the variable highlights look better, in particular the
(identifier) @variable
highlights variables as they are used (rather than assigned). It's not always different than them being not highlighted depending on the theme - some themes highlight variables the same as the foreground theme.
Also I think it would make sense to replace the @include
scope with @namespace
based on how it's used.
I haven't used vala before though so I might be wrong about these
… `genie` from file types
…. Although meson build is very common in vala project.
rebased and applied suggested changes. |
Thanks! |
fix #2224
one question: Vala allows comments to be recorded in code in different ways. but in
languages.toml
we can only config a singlecomment-token = "//"
, how can we to block comment toggle action ?refs:
lang server: https://github.com/vala-lang/vala-language-server
ts: https://github.com/vala-lang/tree-sitter-vala
https://wiki.gnome.org/Projects/Vala/StringSample
https://learnxinyminutes.com/docs/vala/
https://naaando.gitbooks.io/the-vala-tutorial/content/en/3-basics/comments.html
demo vala code to test: