Theme key to change highlight of selected line numbers #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudormrfbin
changed the title
archseer
requested changes
Jun 14, 2021
sudormrfbin
force-pushed
the
theme-set-current-linenr
branch
from
63b11ac
to
4e5fa45
Compare
|
Falls back to |
sudormrfbin
force-pushed
the
theme-set-current-linenr
branch
2 times, most recently
from
b2a0ee4
to
b370bb9
Compare
pickfire
reviewed
Jun 15, 2021
pickfire
reviewed
Jun 15, 2021
pickfire
reviewed
Jun 15, 2021
pickfire
approved these changes
Jun 15, 2021
pickfire
reviewed
Jun 15, 2021
Adds `ui.linenr.selected` which controls highlight of linu numbes which have cursors on. - Fallback to linenr if linenr.selected is missing - Update docs and themes - Add TODOs for themes with temporary linenr.selected
sudormrfbin
force-pushed
the
theme-set-current-linenr
branch
from
b370bb9
to
14123a7
Compare
|
Added the TODOs |
pickfire
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ui.linenr.selectedwhich controls highlight of line numbers which have cursors on them. Selections are now rendered before the gutter to accommodate this change (is this important ?).TODO:
contrib/theme files to include new key