Allow a custom delay before a command popup shows up

[lenstr]

Hi!

This pull request closes #1475.

[EpocSquadron]

There's an interesting edge case with regards to the m key -- the intiial m respects the delay, but selection of i or a which brings up another menu does not. I think this is because the auto-info for inside/around is implemented separately from the normal auto-info for all keybinds. There's been talk of reworking that so the autoinfo for inside and around do use the same method of deriving from keybinds, so maybe we could leave it until then as it will resolve itself at that point. Up to you if you want to spend the time to fix it now.

Other than that, this works really well, nice job!

[EpocSquadron]

I wonder if it wouldn't be unjust to make a default value of 600 -- in my testing it feels like about the delay i would have when unsure of the keybind i want, while not showing up for times when im a little slower to press the next binding when i do know what it is.

[the-mikedavis]

There's a PR reworking mi/ma: #1723 that may help with that, although it's been quiet for a bit and could probably be superseded.

[the-mikedavis]

Places where we call cx.on_next_key don't get the effect of the delay, like select_textobject in commands.rs. We may want to introduce a cx.on_next_key_with_autoinfo like Kakoune has so we can close over adding fake autoinfo with delay nicely https://github.com/mawww/kakoune/blob/689553c2e9b953a9d3822528d4ad858af95fb6a2/src/input_handler.hh#L190

[the-mikedavis]

Ah this is clever - this doesn't need to be triggered explicitly because it's marked as completed in the Drop implementation for Sender, eh?

It's probably worth a comment here on how this triggers since it's kinda hidden in the implementation details

[the-mikedavis]

I don't think it would be too unreadable to have the matches! in the if expression here. I don't feel strongly about it though and I think you did this for readability so it's up to you if you want to keep it as-is

[ksandvik]

Any chance to add in the case of 0 (ms), then the popup is never shown? Even better per command so it could be customized in config.toml?

[the-mikedavis]

You can disable the auto-info boxes entirely already with the editor.auto-info option:

# ~/.config/helix/config.toml
[editor]
auto-info = false

[cd-a]

Is this PR abandoned? I love this feature

[pse403]

Agreed, I'd love it too. I've become addicted to using this editor. I wish my Rust was more advanced so I could contribute. Meantime I can only echo that this feature would solve the one thing that constantly annoys me.

[arexon]

I would really love to see this merged soon!

[pascalkuthe]

closing this one out as stale. Thank you for contributing!