add code for diagnostic. #3096
Merged
add code for diagnostic. #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR provides a solution to resolve helix-editor#2994. missing Code Actions for lsp
pickfire
reviewed
Jul 20, 2022
Comment on lines
+81
to
+87
| let code = match diag.code.clone() { | ||
| Some(x) => match x { | ||
| NumberOrString::Number(x) => Some(lsp::NumberOrString::Number(x)), | ||
| NumberOrString::String(x) => Some(lsp::NumberOrString::String(x)), | ||
| }, | ||
| None => None, | ||
| }; |
There was a problem hiding this comment.
thanks , String not support Copy ., i remove clone
let code = match diag.code.as_ref() {
Some(x) => match x {
NumberOrString::Number(n) => Some(lsp::NumberOrString::Number(*n)),
NumberOrString::String(s) => Some(lsp::NumberOrString::String(s.to_string())),
},
None => None,
};I not sure how to write is better,
There was a problem hiding this comment.
Sorry, accidentally deleted a comment by @archseer. Please use clone, it's the same thing.
erasin
force-pushed
the
lsp-miss-code-action
branch
from
8e4240e
to
a127242
Compare
pickfire
reviewed
Jul 23, 2022
Comment on lines
+26
to
+30
| #[derive(Debug, Eq, Hash, PartialEq, Clone, Deserialize, Serialize)] | ||
| pub enum NumberOrString { | ||
| Number(i32), | ||
| String(String), | ||
| } |
There was a problem hiding this comment.
Do we have to match lsp_types name using NumberOrString or would we be better off using DiagnosticCode?
There was a problem hiding this comment.
it can express its meaning that is good.
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* add code for diagnostic. This PR provides a solution to resolve helix-editor#2994. missing Code Actions for lsp * remote unused import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a solution to resolve #2994. missing Code Actions for lsp