Avoid setting stdin handle when not necessary #3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid setting the stdin handle in `shell_impl` when the input argument is None. This permits to run commands with no stdin with :sh
AceofSpades5757
approved these changes
Jul 30, 2022
|
I think this can cause problems with some programs. I'll usually let high-level functions handle anything too fancy and go with a heuristic approach to get simple scripts (like build scripts) to work. |
|
That looks infinitely cleaner. |
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* Avoid setting stdin handle when not necessary Avoid setting the stdin handle in `shell_impl` when the input argument is None. This permits to run commands with no stdin with :sh * refactoring to avoid code duplication * making clippy happy * Process variable name fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Another small PR which avoids adding the stdin handler in
shell_implwhen not necessary.This allows to run commands that don't expect any stdin whtout getting a
ENOTTYerror.While this works, I have no experience with terminals (and rust), so it might be the completely wrong approach.