Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Doom's Acario dark theme. #3308

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Add Doom's Acario dark theme. #3308

merged 2 commits into from
Aug 6, 2022

Conversation

Aethrexal
Copy link
Contributor

This theme is ported from acario themes from Doom Emacs.

I've however only focused on the dark one as that's the one I'm using.

Add Doom's Acario dark theme.
7022548 
This theme is ported from [acario themes](https://github.com/doomemacs/themes/blob/master/themes/doom-acario-dark-theme.el) from Doom Emacs.

I've however only focused on the dark one as that's the one I'm using.
@the-mikedavis the-mikedavis self-requested a review August 2, 2022 21:26
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Aug 2, 2022
@AlexanderBrevig
Copy link
Contributor

AlexanderBrevig commented Aug 3, 2022 •
edited
Loading

Nice!

I ran it through #3234 and got

"acario":[
	"ui.cursorline"
]

I think ui.cursorline should be defined.

It may be argued that ui.statusline.normal|insert|select should be sepecified as well, in order to adhere to the editor.color-modes setting?

Update doom_acario_dark.toml
90835e1 
Added `ui.cursorline`, `ui.statusline.normal/insert/select`
@Aethrexal
Copy link
Contributor Author

I didn't see anything different when I defined those, but I added them!
Statusline is the same color either way.

@AlexanderBrevig
Copy link
Contributor

I didn't see anything different when I defined those, but I added them! Statusline is the same color either way.

Both of them are behind setting. You must enable color-modes and cursorline (I just realized this may not be available if you use an official release. Thanks for adding anyway)

the-mikedavis
the-mikedavis approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks! 🎨

Could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@the-mikedavis the-mikedavis merged commit 7176c84 into helix-editor:master Aug 6, 2022
@Aethrexal Aethrexal deleted the patch-1 branch August 6, 2022 20:50
@Aethrexal
Copy link
Contributor Author

Looks nice, thanks! art

Could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

Will do!

thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@thomasskk
Add Doom's Acario dark theme. (helix-editor#3308)
6ce4d1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aethrexal @AlexanderBrevig @the-mikedavis