Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust queries: add (function_item) as a local scope #3345

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Rust queries: add (function_item) as a local scope #3345

merged 1 commit into from
Aug 6, 2022

Conversation

ChrHorn
Copy link
Contributor

@ChrHorn ChrHorn commented Aug 6, 2022

Function parameter highlighting was leaking into other scopes.

before:
image

after:
image

@ChrHorn
Rust queries: add (function_item) as a local scope
427d1e0 
Function parameter highlighting was leaking into other scopes.
the-mikedavis
the-mikedavis approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@the-mikedavis the-mikedavis merged commit 23f4a40 into helix-editor:master Aug 6, 2022
@ChrHorn ChrHorn deleted the rust-locals branch August 6, 2022 11:40
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@ChrHorn @thomasskk
Rust queries: add (function_item) as a local scope (helix-editor#3345)
6ece0ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrHorn @the-mikedavis