Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorten output for grammar fetching and building #3396

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

poliorcetics
Copy link
Contributor

@poliorcetics poliorcetics commented Aug 11, 2022

feat: shorten output for grammar fetching and building

New look:

Fetching 102 grammars
98 up to date git grammars
4 updated grammars
        bash      now on 275effdfc0edce774acf7d481f9ea195c6c403cd
        beancount now on 4cbd1f09cd07c1f1fabf867c2cf354f9da53cc4c
        c         now on f05e279aedde06a25801c3f2b2cc8ac17fac52ae
        c-sharp   now on 53a65a908167d6556e1fcdb67f1ee62aac101dda
Building 102 grammars
100 grammars already built
2 grammars built now
        ["bash", "rust"]

@poliorcetics
Copy link
Contributor Author

The output is entirely modifiable, I just find the current one horrid to work with: it's not sorted alphabetically, it's hard to see what was updated and was not, what's not a Git grammar and what is, errors can happen at anytime.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the current fetching/building messages are super verbose. This will be a nice improvement 👍

helix-loader/src/grammar.rs Outdated Show resolved Hide resolved
helix-loader/src/grammar.rs Outdated Show resolved Hide resolved
helix-loader/src/grammar.rs Outdated Show resolved Hide resolved
helix-loader/src/grammar.rs Outdated Show resolved Hide resolved
helix-loader/src/grammar.rs Outdated Show resolved Hide resolved
helix-loader/src/grammar.rs Outdated Show resolved Hide resolved
New look:

```
Fetching 102 grammars
98 up to date git grammars
4 updated grammars
        bash      now on 275effdfc0edce774acf7d481f9ea195c6c403cd
        beancount now on 4cbd1f09cd07c1f1fabf867c2cf354f9da53cc4c
        c         now on f05e279aedde06a25801c3f2b2cc8ac17fac52ae
        c-sharp   now on 53a65a908167d6556e1fcdb67f1ee62aac101dda
```

```
Building 102 grammars
100 grammars already built
2 grammars built now
        ["bash", "rust"]
```
@poliorcetics
Copy link
Contributor Author

Updated the top comment with the new look after review

Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The new output looks great 👍🏻

@archseer archseer merged commit 6618cf2 into helix-editor:master Aug 17, 2022
@poliorcetics poliorcetics deleted the shorter-grammar-update branch August 17, 2022 07:18
AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
…3396)

New look:

```
Fetching 102 grammars
98 up to date git grammars
4 updated grammars
        bash      now on 275effdfc0edce774acf7d481f9ea195c6c403cd
        beancount now on 4cbd1f09cd07c1f1fabf867c2cf354f9da53cc4c
        c         now on f05e279aedde06a25801c3f2b2cc8ac17fac52ae
        c-sharp   now on 53a65a908167d6556e1fcdb67f1ee62aac101dda
```

```
Building 102 grammars
100 grammars already built
2 grammars built now
        ["bash", "rust"]
```
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
…3396)

New look:

```
Fetching 102 grammars
98 up to date git grammars
4 updated grammars
        bash      now on 275effdfc0edce774acf7d481f9ea195c6c403cd
        beancount now on 4cbd1f09cd07c1f1fabf867c2cf354f9da53cc4c
        c         now on f05e279aedde06a25801c3f2b2cc8ac17fac52ae
        c-sharp   now on 53a65a908167d6556e1fcdb67f1ee62aac101dda
```

```
Building 102 grammars
100 grammars already built
2 grammars built now
        ["bash", "rust"]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants