Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid command execution hooks on closed docs #3613

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Avoid command execution hooks on closed docs #3613

merged 1 commit into from
Aug 31, 2022

Conversation

the-mikedavis
Copy link
Member

Fixes a panic with a config like:

[keys.normal.space]
x = [":buffer-close"]

by bailing out of the command-execution handling if the document
doesn't exist after handling a command.

See #2634 (comment)

@the-mikedavis
Avoid command execution hooks on closed docs
f3f16a5 
Fixes a panic with a config like:

    [keys.normal.space]
    x = [":buffer-close"]

by bailing out of the command-execution handling if the document
doesn't exist after handling a command.
@the-mikedavis the-mikedavis mentioned this pull request Aug 31, 2022
Merged
@the-mikedavis the-mikedavis added this to the 22.08 milestone Aug 31, 2022
@archseer archseer merged commit 93c6a33 into helix-editor:master Aug 31, 2022
@the-mikedavis the-mikedavis deleted the md-no-hooks-on-doc-close branch August 31, 2022 16:22
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@the-mikedavis @thomasskk
Avoid command execution hooks on closed docs (helix-editor#3613)
20334a4 
Fixes a panic with a config like:

    [keys.normal.space]
    x = [":buffer-close"]

by bailing out of the command-execution handling if the document
doesn't exist after handling a command.
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
@the-mikedavis @jdrst
Avoid command execution hooks on closed docs (helix-editor#3613)
37176de 
Fixes a panic with a config like:

    [keys.normal.space]
    x = [":buffer-close"]

by bailing out of the command-execution handling if the document
doesn't exist after handling a command.
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
@the-mikedavis
Avoid command execution hooks on closed docs (helix-editor#3613)
9eedbd2 
Fixes a panic with a config like:

    [keys.normal.space]
    x = [":buffer-close"]

by bailing out of the command-execution handling if the document
doesn't exist after handling a command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
22.08
Development

Successfully merging this pull request may close these issues.
2 participants
@the-mikedavis @archseer