Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Great Line Ending & Cursor Range Cleanup #376

Merged
merged 61 commits into from
Jul 29, 2021
Merged

The Great Line Ending & Cursor Range Cleanup #376

merged 61 commits into from
Jul 29, 2021

Commits on Jul 1, 2021

  1. Change the Range type and associated functions to gap indexing.

    @cessen
    cessen committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    c1b0a71 View commit details
    Browse the repository at this point in the history

  2. Add Range methods for various kinds of validation.

    @cessen
    cessen committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    d070747 View commit details
    Browse the repository at this point in the history

  3. Better validation method APIs for Range. 

    This way they do less work, are more specific to what we actually
need, and they compose.
    @cessen
    cessen committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    77a266e View commit details
    Browse the repository at this point in the history

  4. Clean up Selection to not use so many allocations.

    @cessen
    cessen committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    0ae522f View commit details
    Browse the repository at this point in the history

  5. Make Selection's normalize and transform methods self-consuming only.

    @cessen
    cessen committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    7c7be6d View commit details
    Browse the repository at this point in the history

  6. Ensure a minimum selection width on commands that need it.

    @cessen
    cessen committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    e725957 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2021

  1. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    2224a15 View commit details
    Browse the repository at this point in the history

  2. Fix a couple additional unused warnings after merge.

    @cessen
    cessen committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    230248b View commit details
    Browse the repository at this point in the history

  3. Allow last line in file to lack a line break character.

    @cessen
    cessen committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    22dca3b View commit details
    Browse the repository at this point in the history

  4. Make new documents empty, rather than starting with a line ending.

    @cessen
    cessen committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    7961a13 View commit details
    Browse the repository at this point in the history

  5. Fix empty document test.

    @cessen
    cessen committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    28627f9 View commit details
    Browse the repository at this point in the history

  6. Make horizontal selection movement work properly.

    @cessen
    cessen committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    28d2d68 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2021

  1. Make vertical selection movement work properly.

    @cessen
    cessen committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    6e15c9b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    85d5b39 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Implement Range::put() which manages range movements and extensions. 

    In particular, this wraps the annoying logic involved in keeping the
cursor width to 1 grapheme.
    @cessen
    cessen committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    753f7f3 View commit details
    Browse the repository at this point in the history

  2. Update surround commands to work with gap indexing.

    @cessen
    cessen committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    b4c59b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2021

  1. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    a77274e View commit details
    Browse the repository at this point in the history

  2. Update change-case commands to work with gap indexing.

    @cessen
    cessen committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    954314a View commit details
    Browse the repository at this point in the history

  3. Update extend_line command to work with gap indexing.

    @cessen
    cessen committed Jul 17, 2021
    Configuration menu
    Copy the full SHA
    c2fd55e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2021

  1. Update word selection/navigation to work with gap indexing. 

    Also tweaked some of the existing behavior that seemed inconsistent
and/or buggy.  It's mostly identical, just a few corner cases are
different.
    @cessen
    cessen committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    6c038bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    e462f32 View commit details
    Browse the repository at this point in the history

  3. Fix last line number being drawn in the status bar.

    @cessen
    cessen committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    1a9ae72 View commit details
    Browse the repository at this point in the history

  4. Properly fix last_line view calculation. 

    Turned out to be simpler than I thought.  Didn't even need to change the
other use-sites.
    @cessen
    cessen committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    079d4ed View commit details
    Browse the repository at this point in the history

  5. Fixed primary cursor position calculation to use 1-width semantics. 

    This had a bunch of knock-on effects that were buggy, such as bracket
match highlighting.
    @cessen
    cessen committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    b0311f4 View commit details
    Browse the repository at this point in the history

  6. Handle edge case in range_to_target() correctly.

    @cessen
    cessen committed Jul 19, 2021
    Configuration menu
    Copy the full SHA
    e98d669 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Fix extend line behavior.

    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    13b0784 View commit details
    Browse the repository at this point in the history

  2. Fix Selection::push() to make the pushed range primary. 

    Apparently I accidentally deleted that behavior in the cleanup.
    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    c400a60 View commit details
    Browse the repository at this point in the history

  3. Make search work a little nicer when there are already selections. 

    Specifically, if you have text like "aaaaaaaaa" and you search
for "a", the new behavior will actually progress through all of the
"a"s, whereas the previous behavior would be stuck on a single one.
    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1792dc6 View commit details
    Browse the repository at this point in the history

  4. Fix incorrect line hihglight when a selection is at the end of a line.

    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1910fa7 View commit details
    Browse the repository at this point in the history

  5. Fix line-wise p pasting before the current line instead of after.

    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    e8a3980 View commit details
    Browse the repository at this point in the history

  6. Fix various bugs related to goto-end-of-line command. 

    This also fixes a bug with `Selection::normalize()`, that could
result in an out-of-bounds primary index.
    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1c6b558 View commit details
    Browse the repository at this point in the history

  7. Fix comment toggle command also sometimes toggling the next line.

    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    c9300ec View commit details
    Browse the repository at this point in the history

  8. Use new Range::line_range() method in more places, as appropriate.

    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1194fc8 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d5534a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. Fixes for misc bugs with view movement.

    @cessen
    cessen committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    c848ed7 View commit details
    Browse the repository at this point in the history

  2. Don't insert a final line ending on file load/reload.

    @cessen
    cessen committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    198fe40 View commit details
    Browse the repository at this point in the history

  3. Fix selections not being modified quite correctly with text edits.

    @cessen
    cessen committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    bc85c85 View commit details
    Browse the repository at this point in the history

  4. Fix yank not working with internally zero-width ranges.

    @cessen
    cessen committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    063aa94 View commit details
    Browse the repository at this point in the history

  5. Fix append mode not editing correctly. 

    This is currently a bit of a hack, and still doesn't behave quite how we
probably want.  Left a TODO.
    @cessen
    cessen committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    7d07704 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Use Range::line_range() in some more places I missed.

    @cessen
    cessen committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    673338b View commit details
    Browse the repository at this point in the history

  2. Calculate the line that the range head is on correctly.

    @cessen
    cessen committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    5841954 View commit details
    Browse the repository at this point in the history

  3. Revert display-width-based vertical cursor movement. 

    Still needs to be done, but should be part of a separate PR.
    @cessen
    cessen committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    fd684ef View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Fix ocassional panic when matching brackets.

    @cessen
    cessen committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ffb8057 View commit details
    Browse the repository at this point in the history

  2. Fix append mode, and make insertion always happen at head of range.

    @cessen
    cessen committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ad814b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2021

  1. Put selection in separate variable in commands code.

    @cessen
    cessen committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    427ae6a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    4359404 View commit details
    Browse the repository at this point in the history

  3. Fix surround replace command replacing the wrong position on the right.

    @cessen
    cessen committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    8f43dc4 View commit details
    Browse the repository at this point in the history

  4. Fixed find_till_char and find_char commands. 

    They worked correctly when extending, but not for normal cursor
movement.
    @cessen
    cessen committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    2072349 View commit details
    Browse the repository at this point in the history

  5. Switch to a cleaner range-head moving abstraction. 

    Also fix a bunch of bugs related to it.
    @cessen
    cessen committed Jul 24, 2021
    Configuration menu
    Copy the full SHA
    f96b8b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Collect some common patterns into methods on Range.

    @cessen
    cessen committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    0883b4f View commit details
    Browse the repository at this point in the history

  2. Start searches at the right side of the block cursor.

    @cessen
    cessen committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    01247ac View commit details
    Browse the repository at this point in the history

  3. Address some PR comments.

    @cessen
    cessen committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    5ee6ba5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    f62ec6e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Improve Range documentation and organization.

    @cessen
    cessen committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b2c76dc View commit details
    Browse the repository at this point in the history

  2. Add unit tests for some of the new Range methods.

    @cessen
    cessen committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    5229c53 View commit details
    Browse the repository at this point in the history

  3. Use match for branching on the Direction enum in more places.

    @cessen
    cessen committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    84f8167 View commit details
    Browse the repository at this point in the history

  4. Minor cleanup of the vertical movement code.

    @cessen
    cessen committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    aead4e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Merge branch 'master' into great_line_ending_and_cursor_range_cleanup

    @cessen
    cessen committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    a873e71 View commit details
    Browse the repository at this point in the history

  2. Enforce cursor/selection invariants in one place. 

    Rather than per-command like before.
    @cessen
    cessen committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    cd7302f View commit details
    Browse the repository at this point in the history

  3. Fix bug with / searching after non-ascii characters. 

    Forgot to convert from char indices to byte indices before passing
to the regex engine.
    @cessen
    cessen committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    285aba2 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Fix typo in comment.

    @cessen
    cessen committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    e4d41d0 View commit details
    Browse the repository at this point in the history