Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color palettes #393

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Color palettes #393

merged 6 commits into from
Jun 30, 2021

Conversation

jbaa
Copy link
Contributor

@jbaa jbaa commented Jun 29, 2021

This pull request enables theme files to define a palette of named colors, and refer to them in the configuration values that assign colors to UI elements.

Working with a restricted set of colors facilitates theme creation. Additionally, the use of named color identifiers improves the readability of theme files.

The CL includes a theme file that demonstrates this feature by defining a theme using the gruvbox dark color palette.

@archseer
Copy link
Member

This looks reasonable but it needs a bit of documenting in book/src/themes.md :)

@archseer
Copy link
Member

I'll probably migrate over the default theme.toml after this is merged

@pickfire
Copy link
Contributor

pickfire commented Jun 30, 2021

cc @DrZingo who may be better at reviewing this

I don't know how the choices behind the number of palettes.

Copy link
Contributor

@DrZingo DrZingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo on purple0's color. The naming of 5 bg palette colors is consistent with the naming of gruvbox.

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@archseer archseer merged commit 79f0969 into helix-editor:master Jun 30, 2021
@archseer
Copy link
Member

Thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants