Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test flakes in CI #4391

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Fix integration test flakes in CI #4391

merged 3 commits into from
Oct 20, 2022

Commits on Oct 20, 2022

  1. Use helix_view::apply_transaction in integration-tests 

    `helix_view::apply_transaction` closes over `Document::apply` and
`View::apply` to ensure that jumplist entries are updated when a
document changes from a transaction. `Document::apply` shouldn't
be called directly - this helper function should be used instead.
    @the-mikedavis
    the-mikedavis committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    15facc0 View commit details
    Browse the repository at this point in the history

  2. Remove language-server configuration in integration tests 

    This change removes language server configuration from the default
languages.toml config for integration tests. No integration-tests
currently depend on the availability of a language server but if any
future test needs to, it may provide a language server configuration
by passing an override into the `test_syntax_conf` helper.

Language-servers in integration tests cause false-positive failures
when running integration tests in GitHub Actions CI. The Windows
runner appears to have `clangd` installed and all OS runners have
the `R` binary installed but not the `R` language server package.
If a test file created by `tempfile::NamedTempFile` happens to have a
file extension of `r`, the test will most likely fail because the
R language server will fail to start and will become a broken pipe,
meaning that it will fail to shutdown within the timeout, causing a
false-positive failure. This happens surprisingly often in practice.

Language servers (especially rust-analyzer) also emit unnecessary
log output when initializing, which this change silences.
    @the-mikedavis
    the-mikedavis committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    7d7ee75 View commit details
    Browse the repository at this point in the history

  3. Silence dead_code warning on AppBuilder::with_config 

    This function is not currently used but is likely to be useful in
the future, so this change silences the dead_code warning.
    @the-mikedavis
    the-mikedavis committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c4875cc View commit details
    Browse the repository at this point in the history