Add ctrl-z to suspend #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
force-pushed
the
suspend
branch
6 times, most recently
from
528c0de
to
95d8871
Compare
pickfire
commented
Jul 20, 2021
|
Now will restore to block cursor on suspend, but not sure if it will affect people whose cursor isn't block by default. Not sure if there is any way to discover it. |
archseer
reviewed
Jul 22, 2021
pickfire
force-pushed
the
suspend
branch
3 times, most recently
from
9727b39
to
72bb537
Compare
pickfire
commented
Jul 27, 2021
| signal_hook_tokio::Signals, | ||
| }; | ||
| #[cfg(windows)] | ||
| type Signals = futures_util::stream::Empty<()>; |
There was a problem hiding this comment.
Ah, I didn't know you mean like this. I thought you just do futures_util::stream::Empty below instead.
|
@archseer Thanks, with your commit seemed way better. |
archseer
reviewed
Jul 30, 2021
| @@ -502,6 +502,7 @@ impl Default for Keymaps { | |||
| }, | |||
|
|
|||
| "\"" => select_register, | |||
| "C-z" => suspend, | |||
There was a problem hiding this comment.
I don't think this is something that we need to explicitly document. Users will expect this to work since all cli is expected to use ctrl-z for suspend (at least I am not aware of any that does not support this). I did look into that but not sure which category to put last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why but the cursor seemed to be gone be broken right after it suspend.
tput resetdoes fix it.