Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only write newlines in menu selection popup if the lsp returns detail #4902

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Only write newlines in menu selection popup if the lsp returns detail #4902

merged 1 commit into from
Dec 9, 2022

Conversation

ath3
Copy link
Contributor

@ath3 ath3 commented Nov 26, 2022

Before:
menu_selection_popup_before

After:
menu_selection_popup_after

@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Nov 27, 2022
@ath3 ath3 mentioned this pull request Dec 6, 2022
Merged
@the-mikedavis the-mikedavis merged commit 6798a66 into helix-editor:master Dec 9, 2022
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
@ath3
Only write newlines in menu selection popup if the lsp returns detail (…
b6b8f1a 
…helix-editor#4902)
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
@ath3
Only write newlines in menu selection popup if the lsp returns detail (…
6d9e034 
…helix-editor#4902)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ath3 @the-mikedavis @kirawi