Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction composition order in History::changes_since #4981

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Fix transaction composition order in History::changes_since #4981

merged 2 commits into from
Dec 3, 2022

Commits on Dec 3, 2022

  1. Add a undo/redo split test case for crossing branches

    @the-mikedavis
    the-mikedavis committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    fc06ca8 View commit details
    Browse the repository at this point in the history

  2. history: Switch up/down transaction chaining order 

    The old code tends to work in practice because, usually, either up_txns
or down_txns are empty. When both have contents though, we can run into
a panic trying to compose them all since they will disagree on the
length of the text. This fixes the panic test case in the parent
commit.
    @the-mikedavis
    the-mikedavis committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    744f49b View commit details
    Browse the repository at this point in the history