Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Haskell text objects #5061

Merged
merged 1 commit into from
Dec 10, 2022
Merged

Add Haskell text objects #5061

merged 1 commit into from
Dec 10, 2022

Conversation

ocharles
Copy link
Contributor

@ocharles ocharles commented Dec 8, 2022

No description provided.

@ocharles
Copy link
Contributor Author

ocharles commented Dec 8, 2022

The only thing I don't like about this is that selecting a function seems to select all the whitespace up to the next function. I'm not sure if anything can be done here, or if the tree-sitter grammar needs to be tweaked:

image

@pascalkuthe pascalkuthe added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Dec 8, 2022
@pascalkuthe
Copy link
Member

Please regenerate the documentaiton with cargo xtask docgen to make the CI green

@ocharles
Copy link
Contributor Author

Thanks for the hint @pascalkuthe! All sorted now

@the-mikedavis the-mikedavis merged commit 0e8ea13 into helix-editor:master Dec 10, 2022
@the-mikedavis
Copy link
Member

The only thing I don't like about this is that selecting a function seems to select all the whitespace up to the next function. I'm not sure if anything can be done here, or if the tree-sitter grammar needs to be tweaked

Yeah this would need to be changed upstream in the tree-sitter grammar

herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
@ocharles
Add Haskell text objects (helix-editor#5061)
dcb0499
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
@ocharles
Add Haskell text objects (helix-editor#5061)
2f9afa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ocharles @pascalkuthe @the-mikedavis