Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme inheritance for default themes #5218

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

hunterliao29
Copy link
Contributor

close #5156

@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 20, 2022
helix-view/src/theme.rs Outdated Show resolved Hide resolved
helix-view/src/theme.rs Outdated Show resolved Hide resolved
helix-view/src/theme.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis changed the title theme inherent for default theme Fix theme inheritance for default themes Dec 30, 2022
@the-mikedavis the-mikedavis merged commit 63dcaae into helix-editor:master Dec 30, 2022
@hunterliao29 hunterliao29 deleted the inherit_theme branch December 30, 2022 16:25
semin-park pushed a commit to semin-park/helix that referenced this pull request Jan 4, 2023
semin-park pushed a commit to semin-park/helix that referenced this pull request Jan 4, 2023
hadronized pushed a commit to hadronized/helix that referenced this pull request Jan 4, 2023
freqmod pushed a commit to freqmod/helix that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inherit does not work with base16_theme
4 participants