Update grammar and highlight queries for slint grammar rewrite #5290
Conversation
|
Ahh. I accidentally have an extra unrelated commit in here. I'll fix that |
Update slint highlight queries for grammar rewrite Revert "Add scrolling down past half the buffer height" This reverts commit 4155026.
|
Fixed |
There was a problem hiding this comment.
It looks like local.scm will need to be updated as well since it contains a node that doesn't exist in the new version of the grammar: https://github.com/helix-editor/helix/actions/runs/3777270745/jobs/6422763958
runtime/queries/slint/highlights.scm
Outdated
| (ternary_expression [":" "?"] @keyword.control.conditional) No newline at end of file | ||
| (ternary_expression [":" "?"] @conditional) |
There was a problem hiding this comment.
Helix uses different captures for highlighting than neovim - https://docs.helix-editor.com/master/themes.html#syntax-highlighting- so this change should be undone
There are some other non-existent scopes that should be changed too, for example @float should become @constant.numeric.float
kirawi
added
S-waiting-on-author
|
Has there been any progress on this issue? |
|
I haven’t worked on this in a while. There isn’t much that needs changed at this point but the queries need to be updated for helix |
|
Closed by #7893 |
This is just updating the grammar rev and queries to be updated to the latest slint grammar.