Show file preview in split pane in fuzzy finder #534
Conversation
The current selected item is cloned on every event, which is undesirable
Files already loaded in memory have syntax highlighting enabled
|
I think this is good enough to merge after you resolve that last TODO :) |
|
Done :) |
helix-term/src/compositor.rs
Outdated
| for layer in &self.layers { | ||
| layer.render(area, surface, cx) | ||
| for layer in &mut self.layers { | ||
| layer.prepare_for_render(cx); |
There was a problem hiding this comment.
Couldn't you just do this in render()?
There was a problem hiding this comment.
That would require changing render() to take a mutable ref to self, since it calculates the preview and stores it in the cache. I didn't want to do that since having a render function that could potentially change the state seemed like questionable design; should I simply have render() take &mut self ?
There was a problem hiding this comment.
The signature of render already takes a mut: pub fn render(&mut self, cx: &mut Context) I think I changed that for some ui component previously for the same reasons.
There was a problem hiding this comment.
I meant Component's render function actually; changed it to take &mut self anyway since the topmost render takes mutable reference anyway.
|
I think you forgot to push the latest commits! I'll do a review once those are up. |
TODO
EditorView::render_buffer()Bugs
helix/helix-view/src/view.rs
Line 124 in ab41e45