Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update catppuccin themes #5404

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Conversation

beeb
Copy link
Contributor

@beeb beeb commented Jan 4, 2023

According to latest changes in https://github.com/catppuccin/helix

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 5, 2023
@ivktac ivktac mentioned this pull request Jan 6, 2023
@archseer
Copy link
Member

archseer commented Jan 7, 2023

Can you also bring in the inherits change from #4581?

@beeb
Copy link
Contributor Author

beeb commented Jan 7, 2023

This would have to be done in the upstream I guess. I don't feel comfortable changing the theme in this repo when the official theme repo doesn't implement those changes.

@ivktac
Copy link
Contributor

ivktac commented Jan 7, 2023

This would have to be done in the upstream I guess. I don't feel comfortable changing the theme in this repo when the official theme repo doesn't implement those changes.

it's not about changing the theme but including this feature https://docs.helix-editor.com/master/themes.html#inheritance, where you need only override pallete

@beeb
Copy link
Contributor Author

beeb commented Jan 7, 2023

@seshotake @archseer gotcha, I misunderstood, sorry. I can do it here, not sure if the upstream should use this as they might want to keep each theme independent of the others. For the default helix it makes sense though. Pushing in a sec.

@the-mikedavis the-mikedavis merged commit 2412f7c into helix-editor:master Jan 11, 2023
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
@beeb beeb deleted the catppuccin-theme branch March 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants