Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Explorer #5566

Closed
wants to merge 3 commits into from
Closed

Tree Explorer #5566

wants to merge 3 commits into from

Conversation

evertonse
Copy link

Tree Explorer

helix-merge-showcase

@pascalkuthe
Copy link
Member

I am guessing this is a rebase of #2377? It's good practice to credit the original or both in the commits and the PR description.

@pascalkuthe pascalkuthe added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 18, 2023
@archseer
Copy link
Member

Agree, if this is just a rebase the original author should be retained on the commits.

@evertonse
Copy link
Author

Sorry guys, big noob here. I just clicked pull request button as soons as I decided things were working properly.
I intend to credit the original guy @cossonleo . I'm trying to edit the part where I've put the img, but idk how.

@archseer
Copy link
Member

@mvllow
Copy link
Contributor

mvllow commented Jan 19, 2023

Would love to see this work out of the box without needing (I assume) a patched font.

E.g. folder icons:

Screenshot of folder icons in the file explorer rendering as white boxes instead of a folder.

More subjective feedback

Behaviour

Happy to see these as defaults or an added option if other users are also interested

  • Toggle tree visibility via space e instead of toggling focus.
  • Hide preview window when hovering a tree item. This adds a bit of clutter and this functionality exists already inside of space f.
  • Allow sidebar to be swapped to the right side. More useful when quickly toggling the tree open/closed.

Keymaps

Current decisions may be based on technical limitations or to ease maintainability

Merge file/directory commands

For example, replace mf/md (make file/make directory) with a (add file or directory). Create a directory if user input ends with a "/".

Thank you to everyone helping to build this feature, it's much appreciated 💜

@cor
Copy link
Contributor

cor commented Jan 19, 2023

For example, replace mf/md (make file/make directory) with a (add file or directory). Create a directory if user input ends with a "/".

I agree, though it should still take into account the users's current place in the tree

Hide preview window when hovering a tree item. This adds a bit of clutter and this functionality exists already inside of space f.

IMO this should be an option in the user's Helix config. I think having it be disabled by default makes sense, but I also think that it's a very valuable feature for some. space f is not the same as you do not have the context of the files position in the directory structure

Allow sidebar to be swapped to the right side. More useful when quickly toggling the tree open/closed.

Would be nice but not required for the initial PR in my opinion

@kirawi
Copy link
Member

kirawi commented Jan 19, 2023

Would love to see this work out of the box without needing (I assume) a patched font.

It shouldn't, unless this PR also includes #2869

@archseer
Copy link
Member

archseer commented Feb 1, 2023

Replaced by #5768

@archseer archseer closed this Feb 1, 2023
omentic added a commit to omentic/helix-ext that referenced this pull request Nov 1, 2023
omentic added a commit to omentic/helix-ext that referenced this pull request May 1, 2024
omentic added a commit to omentic/helix-ext that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants