Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme(onedark): Add ui.highlight scope #5755

Merged

Conversation

sudormrfbin
Copy link
Member

@sudormrfbin sudormrfbin commented Jan 31, 2023

ui.highlight is used in hightlighting lines in the picker preview. Also change the grey shade of the secondary selections to not obstruct comment text (earlier the bg of secondary selections and fg of comments were the same).

Fixes #5750.

ui.highlight is used in hightlighting lines in the picker preview.
Also change the grey shade of the secondary selections to not
obstruct comment text (earlier the bg of secondary selections and
fg of comments were the same).
@sudormrfbin sudormrfbin added the A-theme Area: Theme and appearence related label Jan 31, 2023
@pascalkuthe
Copy link
Member

LGTM, thanks for fixing that. I have noticed this quite a few times but I never got around to opening a PR/issue 👍

@pascalkuthe pascalkuthe added the S-waiting-on-review Status: Awaiting review from a maintainer. label Jan 31, 2023
@the-mikedavis the-mikedavis merged commit 0f562df into helix-editor:master Jan 31, 2023
@sudormrfbin sudormrfbin deleted the onedark-add-highlight-scope branch February 3, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line unreadble in file preview when cursor is on comment using onedark theme
3 participants