Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump to symbol ranges in LSP goto commands #5986

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Jump to symbol ranges in LSP goto commands #5986

merged 1 commit into from
Mar 8, 2023

Conversation

the-mikedavis
Copy link
Member

This follows prior changes like #4713: we select the range given by the language server rather than the starting point.

@the-mikedavis
Jump to symbol ranges in LSP goto commands
f8b690f 
This follows prior changes like 42ad1a9: we select the range given
by the language server rather than the starting point.
@the-mikedavis the-mikedavis added C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 14, 2023
pascalkuthe
pascalkuthe approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to be consistent here 👍

@archseer archseer merged commit 6dc017b into helix-editor:master Mar 8, 2023
@the-mikedavis the-mikedavis deleted the md-jump-to-lsp-range branch March 8, 2023 02:01
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
@the-mikedavis
Jump to symbol ranges in LSP goto commands (helix-editor#5986)
adaf205 
This follows prior changes like 42ad1a9: we select the range given
by the language server rather than the starting point.
@pascalkuthe pascalkuthe mentioned this pull request Apr 17, 2023
Merged
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@the-mikedavis @wes-adams
Jump to symbol ranges in LSP goto commands (helix-editor#5986)
0a4cdbe 
This follows prior changes like 42ad1a9: we select the range given
by the language server rather than the starting point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-mikedavis @pascalkuthe @archseer