Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Separate diagnostic picker message and code #6095

Merged
merged 1 commit into from
Mar 13, 2023
Merged

LSP: Separate diagnostic picker message and code #6095

merged 1 commit into from
Mar 13, 2023

Conversation

FrancescElies
Copy link
Contributor

Problem
Currently in master lsp errors are reported as follows, as you can see the diagnostic message and code are attached to each other making it hard to read.
grafik

This pr solves that.
grafik

dead10ck
dead10ck previously approved these changes Feb 25, 2023
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me 👍

@the-mikedavis the-mikedavis changed the title LSP: diagnostic picker message and code have no separation LSP: Separate diagnostic picker message and code Mar 13, 2023
@the-mikedavis the-mikedavis merged commit d15f972 into helix-editor:master Mar 13, 2023
@FrancescElies FrancescElies deleted the cesc/diagnostic-picker-message-code-no-separation branch March 13, 2023 17:01
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants