Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: Papercolor: Add ui.highlight #6162

Merged

Conversation

AfoHT
Copy link
Contributor

@AfoHT AfoHT commented Mar 2, 2023

Using the picker with syntax highlighting the
fallback ui.selection makes a lot of text,
especially for the light variant, hard to read.

Instead, use a lighter background for highlights

Using the picker with syntax highlighting the
fallback `ui.selection` makes a lot of text,
especially for the light variant, hard to read.

Instead, use a lighter background for highlights
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 2, 2023
@the-mikedavis the-mikedavis merged commit cf15308 into helix-editor:master Mar 5, 2023
@AfoHT AfoHT deleted the theme_papercolor_ui_highlight branch March 6, 2023 10:00
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Using the picker with syntax highlighting the
fallback `ui.selection` makes a lot of text,
especially for the light variant, hard to read.

Instead, use a lighter background for highlights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants