LSP: No-op client/registerCapability requests #6258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-enhancement
archseer
reviewed
Mar 11, 2023
Some language servers send this request even though we don't enable dynamic capability registration. In some language servers that use the vscode-languageserver-node dependency, replying with an error can cause the server to exit because an un-caught rejected promise is fatal. Replying with a JSONRPC error that the method is not handled is the correct thing to do but given that it causes some language servers in the wild to exit and that ignoring it doesn't cause any harm, we can workaround the exits by just sending an OK and doing nothing. This is similar to a workaround done by neovim.
the-mikedavis
force-pushed
the
workaround-register-capability
branch
from
da82880
to
8689601
Compare
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some language servers send this request even though we don't enable dynamic capability registration. In some language servers that use the vscode-languageserver-node dependency, replying with an error can cause the server to exit because an un-caught rejected promise is fatal.
Replying with a JSONRPC error that the method is not handled is the correct thing to do but given that it causes some language servers in the wild to exit and that ignoring it doesn't cause any harm, we can workaround the exits by just sending an OK and doing nothing. This is similar to a workaround done by neovim.
Recent examples: #6230, #6243