Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme: Use inheritance for gruvbox themes #6295

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

the-mikedavis
Copy link
Member

These gruvbox variants were introduced before theme inheritance and only differ by a few colors. This change cleans up the duplicated theming with theme inheritance.

These gruvbox variants were introduced before theme inheritance and
only differ by a few colors. This change cleans up the duplicated
theming with theme inheritance.
@the-mikedavis the-mikedavis added E-easy Call for participation: Experience needed to fix: Easy / not much A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 13, 2023
@archseer archseer merged commit bb41a28 into helix-editor:master Mar 14, 2023
@the-mikedavis the-mikedavis deleted the md-gruvbox-inherits branch March 14, 2023 03:06
sagnibak pushed a commit to sagnibak/helix that referenced this pull request Mar 21, 2023
These gruvbox variants were introduced before theme inheritance and
only differ by a few colors. This change cleans up the duplicated
theming with theme inheritance.
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
These gruvbox variants were introduced before theme inheritance and
only differ by a few colors. This change cleans up the duplicated
theming with theme inheritance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants