Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow truncation of table row text #6410

Closed
wants to merge 5 commits into from
Closed

Allow truncation of table row text #6410

wants to merge 5 commits into from

Commits on Mar 22, 2023

  1. Truncate paths in the file picker

    @mWalrus
    mWalrus committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    adb12ad View commit details
    Browse the repository at this point in the history

  2. Skip truncation of single character cells in Table 

    Here we assume that spans with content that is 1
in length will not need to be truncated.

This solves an issue with my previous commit that
made the buffer picker truncate the "prefix" cells.
    @mWalrus
    mWalrus committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    772fd46 View commit details
    Browse the repository at this point in the history

  3. Move truncate check into render_cell 

    This removes the need for `render_cell_truncated`.

We now check if we should truncate in `render_cell`
which allows us to skip the additional checks in
`Buffer::set_spans_truncated`.
    @mWalrus
    mWalrus committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    978e1a4 View commit details
    Browse the repository at this point in the history

  4. Move Rect definition into call to render_cell

    @mWalrus
    mWalrus committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b23024a View commit details
    Browse the repository at this point in the history

  5. Simplify Buffer::set_spans_truncated

    @mWalrus
    mWalrus committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    4992429 View commit details
    Browse the repository at this point in the history