:log-open opens the current log file as specified by --log #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
approved these changes
Apr 7, 2023
| @@ -26,6 +28,11 @@ pub fn initialize_config_file(specified_file: Option<PathBuf>) { | |||
| CONFIG_FILE.set(config_file).ok(); | |||
| } | |||
|
|
|||
| pub fn initialize_log_file(specified_file: PathBuf) { | |||
There was a problem hiding this comment.
Like initialize_config_file, this can take an Option<PathBuf> and we can move the directory creation (from here) into that block. That way we don't create the cache_dir unless we use it
pascalkuthe
added
C-enhancement
|
This PR is no unnecessary as the issue it adrwssed was solved by #7573, regardless thank you for your contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MR should fix the issue mentioned in #6469.
I used a similar implementation to
CONFIG_FILE. Tests should still be added but I'll ensure people agree on the implementation first.Fixes #6469